[som] Add bug queue UI.

[som] Add bug queue UI.

BUG=618434
Committed: https://chromium.googlesource.com/infra/infra/+/cb775466e68f6c13ac38946fa4ec40eacb6cae8b

[seanmccullough1, 2016-06-09 21:50:20]

seanmccullough@google.com changed reviewers:
+ martiniss@chromium.org

[martiniss, 2016-06-10 21:11:29]

lgtm

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue.html (right):

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue.html:28:
<iron-ajax
Can you make this able to be refresh? The refresh button currently (after my CL)
refreshes alert streams and annotations.

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue.html:41: <a
href="http://crbug.com/[[item.id]]">http://crbug.com/[[item.id]]</a>
([[item.status]])
Maybe have the link text be 'Bug 123123'? That's semi-standard in monorail
right? Up to you

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/test/som-bug-queue-test.html
(right):

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/test/som-bug-queue-test.html:20: json: {
'Content-Type': 'application/json' },
nit: no spaces around the strings, so {'Content....

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/test/som-bug-queue-test.html:35:
assert.equal(true, element._haveNoBugs({items:[]}));
test false as well?

[seanmccullough1, 2016-06-10 21:23:28]

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue.html (right):

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue.html:28:
<iron-ajax
On 2016/06/10 21:11:28, martiniss wrote:
> Can you make this able to be refresh? The refresh button currently (after my
CL)
> refreshes alert streams and annotations.

added a refresh() method. Is that what you mean?

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue.html:41: <a
href="http://crbug.com/[[item.id]]">http://crbug.com/[[item.id]]</a>
([[item.status]])
On 2016/06/10 21:11:28, martiniss wrote:
> Maybe have the link text be 'Bug 123123'? That's semi-standard in monorail
> right? Up to you

Done.

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/test/som-bug-queue-test.html
(right):

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/test/som-bug-queue-test.html:20: json: {
'Content-Type': 'application/json' },
On 2016/06/10 21:11:29, martiniss wrote:
> nit: no spaces around the strings, so {'Content....

Done.

https://codereview.chromium.org/2053893002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/test/som-bug-queue-test.html:35:
assert.equal(true, element._haveNoBugs({items:[]}));
On 2016/06/10 21:11:29, martiniss wrote:
> test false as well?

Done.

[martiniss, 2016-06-10 21:35:58]

https://codereview.chromium.org/2053893002/diff/40001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right):

https://codereview.chromium.org/2053893002/diff/40001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:264:
this.$.alertsAjax.generateRequest();
add this.$.bugQueue.refresh() here as well

[seanmccullough1, 2016-06-10 21:56:49]

https://codereview.chromium.org/2053893002/diff/40001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right):

https://codereview.chromium.org/2053893002/diff/40001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:264:
this.$.alertsAjax.generateRequest();
On 2016/06/10 21:35:58, martiniss wrote:
> add this.$.bugQueue.refresh() here as well 

Done.

[seanmccullough1, 2016-06-10 21:57:20]

The CQ bit was checked by seanmccullough@google.com

[seanmccullough1, 2016-06-10 21:57:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/2053893002/#ps60001
(title: "refresh")

[commit-bot: I haz the power, 2016-06-10 21:57:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053893002/60001

[commit-bot: I haz the power, 2016-06-10 22:18:23]

Description was changed from

==========
[som] Add bug queue UI.

BUG=618434
==========

to

==========
[som] Add bug queue UI.

BUG=618434

Committed:
https://chromium.googlesource.com/infra/infra/+/cb775466e68f6c13ac38946fa4ec4...
==========

[commit-bot: I haz the power, 2016-06-10 22:18:24]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/cb775466e68f6c13ac38946fa4ec4...