Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3594)

Unified Diff: go/src/infra/appengine/sheriff-o-matic/elements/som-app.html

Issue 2053893002: [som] Add bug queue UI. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: refresh Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
diff --git a/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html b/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
index 7c25c49e9ec85ce37c7cf26136c01add929e73f5..3df60ec8a56db5d2e9e08abfdeefb94cf9203bcd 100644
--- a/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
+++ b/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html
@@ -19,6 +19,7 @@
<link rel="import" href="/bower_components/paper-spinner/paper-spinner.html">
<link rel="import" href="/bower_components/paper-toolbar/paper-toolbar.html">
<link rel="import" href="/elements/som-alert-item.html">
+<link rel="import" href="/elements/som-bug-queue.html">
<link rel="import" href="/elements/som-drawer.html">
<link rel="import" href="/elements/som-examine.html">
@@ -125,10 +126,11 @@
<div class="flex layout vertical">
<iron-pages attr-for-selected='id' selected="[[_selectedPage]]" class="flex layout vertical">
<div id="alertsList">
- <div hidden$="[[_haveAlerts]]">
+ <som-bug-queue id="bugQueue" alerts-group="[[_alertsGroup]]"></som-bug-queue>
+ <div hidden$="[[_haveAlerts]]">
No alerts!
</div>
- <iron-list id="alertsIronList" items="[[_alerts]]" as="alert" class="fit" selection-enabled multi-selection>
+ <iron-list id="alertsIronList" items="[[_alerts]]" as="alert" selection-enabled multi-selection>
<template>
<div class="list-item" tabindex$="[[tabIndex]]">
<som-alert-item
@@ -223,7 +225,7 @@
},
_haveAlerts: {
type: Boolean,
- computed: '_computeHaveAlerts(alerts)',
+ computed: '_computeHaveAlerts(_alerts)',
},
logoutUrl: String,
_networkActive: {
@@ -260,6 +262,7 @@
_refresh: function() {
this.$.alertsAjax.generateRequest();
+ this.$.bugQueue.refresh();
},
_refreshAsync: function() {
@@ -350,9 +353,21 @@
return aAnn.snoozed ? 1 : -1;
});
+ // Otherwise alertsIronList doesn't render all of the alert items.
+ setTimeout(() => {
+ this.$.alertsIronList.notifyResize();
+ }, 250);
+
return alerts;
},
+ _computeHaveAlerts: function(alerts) {
+ if (!alerts) {
+ return true;
+ }
+ return alerts.length > 0;
+ },
+
////////////////////// Annotations ///////////////////////////
_computeAnnotations: function(annotationsJson) {
« no previous file with comments | « no previous file | go/src/infra/appengine/sheriff-o-matic/elements/som-bug-queue.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698