Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2053503003: Clean up layout tests in LayoutTests/shadow-dom/ (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up layout tests in LayoutTests/shadow-dom/ - Remove "v1-" prefix. - Clean up styles - Use makeTestTree() as much as possible Clean up is not finished. Other clean up CLs will come later. BUG=531990 Committed: https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8 Cr-Commit-Position: refs/heads/master@{#398827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -899 lines) Patch
A + third_party/WebKit/LayoutTests/shadow-dom/attachShadow-safelist.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/default-slots.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js View 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-1-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-2-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-api-1.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-api-2.html View 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-api-dynamic.html View 1 chunk +40 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-api-in-v0.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-api-with-closed-shadow-tree.html View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-dom-mutation.html View 1 chunk +53 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-1-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-2-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-3.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-3-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-1.html View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-2.html View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-3.html View 1 chunk +70 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-fallback-api-4.html View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-in-document-tree.html View 1 chunk +43 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-in-v0.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/slots-in-v0-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-text-nodes.html View 1 chunk +46 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-attachShadow-safelist.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-default-slots.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-1.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-1-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-2.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-2-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-1.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-2.html View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-dynamic.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-in-v0.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-api-with-closed-shadow-tree.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dom-mutation.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dynamic.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-dynamic-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-1.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-1-expected.html View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-2.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-2-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-3.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-3-expected.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-1.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-2.html View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-3.html View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-fallback-api-4.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-document-tree.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-v0.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-in-v0-expected.html View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v1-slots-text-nodes.html View 1 chunk +0 lines, -56 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053503003/1
4 years, 6 months ago (2016-06-09 08:33:21 UTC) #2
hayato
PTAL
4 years, 6 months ago (2016-06-09 08:45:13 UTC) #6
kochi
lgtm
4 years, 6 months ago (2016-06-09 09:20:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053503003/1
4 years, 6 months ago (2016-06-09 09:27:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 09:49:27 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 09:51:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fa0e87122906c7957d856576825712667cc0ae8
Cr-Commit-Position: refs/heads/master@{#398827}

Powered by Google App Engine
This is Rietveld 408576698