Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2039813008: Remove unnecessary calling offset{Top,Left} (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary calling offset{Top,Left} All APIs should work without calling offsetXXX explicitly. BUG=531990 Committed: https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e Cr-Commit-Position: refs/heads/master@{#398832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host1.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host2.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host3.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/css-focus-pseudo-match-shadow-host5.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/default-slots.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-with-delegatesFocus.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/focus-slide-on-shadow-host.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/focus-with-dom-mutation.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/inherit-into-slotted.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/slots-api-in-v0.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/slots-dynamic.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v0-inert-features-in-v1-shadow-trees.html View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039813008/1
4 years, 6 months ago (2016-06-09 08:59:55 UTC) #2
hayato
PTAL
4 years, 6 months ago (2016-06-09 09:01:28 UTC) #5
kochi
lgtm
4 years, 6 months ago (2016-06-09 09:17:10 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2053503003 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-09 09:27:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039813008/1
4 years, 6 months ago (2016-06-09 09:53:04 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 10:19:37 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 10:21:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3ec55fdaf8b5691d67e1e8d03ff9c07b436ba4e
Cr-Commit-Position: refs/heads/master@{#398832}

Powered by Google App Engine
This is Rietveld 408576698