Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 205343013: Introduce andp, notp, orp and xorp for x64 port (Closed)

Created:
6 years, 9 months ago by haitao.feng
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Introduce andp, notp, orp and xorp for x64 port R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20276

Patch Set 1 #

Patch Set 2 : Rebased with bleeding_edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -285 lines) Patch
M src/x64/assembler-x64.h View 1 9 chunks +143 lines, -124 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 1 chunk +4 lines, -12 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 13 chunks +13 lines, -13 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/x64/ic-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 35 chunks +51 lines, -51 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 6 chunks +15 lines, -15 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 33 chunks +36 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
PTAL. I will submit a cl to refactor the arithmetic_op function after this cl is ...
6 years, 9 months ago (2014-03-26 03:17:31 UTC) #1
Toon Verwaest
lgtm
6 years, 9 months ago (2014-03-26 09:48:57 UTC) #2
haitao.feng
6 years, 9 months ago (2014-03-26 12:15:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698