Index: base/synchronization/condition_variable_win.cc |
diff --git a/base/synchronization/condition_variable_win.cc b/base/synchronization/condition_variable_win.cc |
index 61c6a715e0eccd8557338193f7f8313ab431b9ce..d5f24e4438753471dc38b0e48a0ae680477eafb2 100644 |
--- a/base/synchronization/condition_variable_win.cc |
+++ b/base/synchronization/condition_variable_win.cc |
@@ -34,8 +34,8 @@ void ConditionVariable::TimedWait(const TimeDelta& max_time) { |
user_lock_->CheckHeldAndUnmark(); |
#endif |
- if (FALSE == SleepConditionVariableSRW(&cv_, srwlock_, timeout, 0)) { |
- DCHECK(GetLastError() != WAIT_TIMEOUT); |
+ if (!SleepConditionVariableSRW(&cv_, srwlock_, timeout, 0)) { |
+ DCHECK_EQ(static_cast<DWORD>(ERROR_TIMEOUT), GetLastError()); |
danakj
2016/06/10 17:37:11
What is the intention of the DCHECK before? It was
robliao
2016/06/10 18:16:12
My interpretation of the DCHECK is that it was a m
danakj
2016/06/10 21:00:09
Ah ok, there are in fact other errors possible. It
sky
2016/09/14 16:35:16
This is a great description of why the DCHECK shou
robliao
2016/09/14 17:49:58
https://codereview.chromium.org/2341773003/ opened
|
} |
#if DCHECK_IS_ON() |