Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/assembler_dbc_test.cc

Issue 2053213004: DBC: Adds BinarySmiOp instruction (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments, fix bugs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/integers.cc ('k') | runtime/vm/constants_dbc.h » ('j') | runtime/vm/flow_graph_compiler_dbc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_dbc_test.cc
diff --git a/runtime/vm/assembler_dbc_test.cc b/runtime/vm/assembler_dbc_test.cc
index 5baa5d6211fcba9583109192e1aa250c35bbf36a..271ea50bacde056f661aaf45e4c9feb15af1edab 100644
--- a/runtime/vm/assembler_dbc_test.cc
+++ b/runtime/vm/assembler_dbc_test.cc
@@ -119,6 +119,22 @@ ASSEMBLER_TEST_RUN(Simple, test) {
}
+ASSEMBLER_TEST_GENERATE(Nop, assembler) {
+ __ PushConstant(Smi::Handle(Smi::New(42)));
+ __ Nop();
+ __ Nop();
+ __ Nop();
+ __ Nop();
+ __ Nop();
+ __ ReturnTOS();
+}
+
+
+ASSEMBLER_TEST_RUN(Nop, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
// Called from assembler_test.cc.
// FP[-kParamEndSlotFromFp - 1]: growable array
// FP[-kParamEndSlotFromFp - 2]: value
@@ -484,6 +500,348 @@ ASSEMBLER_TEST_RUN(GreaterThanTOSNonSmi, test) {
}
+// - Add, Sub, Mul, Div, Mod, Shl, Shr rA, rB, rC
+//
+// Arithmetic operations on Smis. FP[rA] <- FP[rB] op FP[rC].
+// If these instructions can trigger a deoptimization, the following
+// instruction should be Deopt. If no deoptimization should be triggered,
+// the immediately following instruction is skipped.
+ASSEMBLER_TEST_GENERATE(AddNoOverflow, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(20)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(22)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Add(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(AddNoOverflow, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(AddOverflow, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(Smi::kMaxValue)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(1)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Add(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(AddOverflow, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(SubNoOverflow, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(64)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(22)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Sub(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(SubNoOverflow, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(SubOverflow, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(Smi::kMinValue)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(1)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Sub(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(SubOverflow, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(MulNoOverflow, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(-6)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(-7)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Mul(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(MulNoOverflow, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(MulOverflow, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(Smi::kMaxValue)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(-8)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Mul(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(MulOverflow, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(DivNoDeopt, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(27)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(3)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Div(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(DivNoDeopt, test) {
+ EXPECT_EQ(9, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(DivZero, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(3)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(0)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Div(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(DivZero, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(DivCornerCase, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(Smi::kMinValue)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(-1)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Div(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(DivCornerCase, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ModPosPos, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(42)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(4)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Mod(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ModPosPos, test) {
+ EXPECT_EQ(2, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ModNegPos, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(-42)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(4)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Mod(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ModNegPos, test) {
+ EXPECT_EQ(2, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ModPosNeg, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(42)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(-4)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Mod(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ModPosNeg, test) {
+ EXPECT_EQ(2, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ModZero, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(3)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(0)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Mod(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ModZero, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ShlNoDeopt, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(21)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(1)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Shl(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ShlNoDeopt, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ShlOverflow, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(Smi::kMaxValue)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(1)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Shl(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ShlOverflow, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ShlNegShift, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(21)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(-1)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Shl(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ShlNegShift, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ShrNoDeopt, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(84)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(1)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Shr(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(-42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ShrNoDeopt, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(ShrNegShift, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(21)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(-1)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ Shr(2, 0, 1);
+ __ LoadConstant(2, Smi::Handle(Smi::New(42)));
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(ShrNegShift, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+// - BitOr, BitAnd, BitXor rA, rB, rC
+//
+// FP[rA] <- FP[rB] op FP[rC]
+ASSEMBLER_TEST_GENERATE(BitOr, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(0x2)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(0x28)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ BitOr(2, 0, 1);
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(BitOr, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(BitAnd, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(0x2b)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(0x6a)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ BitAnd(2, 0, 1);
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(BitAnd, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(BitXor, assembler) {
+ __ Frame(3);
+ __ LoadConstant(0, Smi::Handle(Smi::New(0x37)));
+ __ LoadConstant(1, Smi::Handle(Smi::New(0x1d)));
+ __ LoadConstant(2, Smi::Handle(Smi::New(-1)));
+ __ BitXor(2, 0, 1);
+ __ Return(2);
+}
+
+
+ASSEMBLER_TEST_RUN(BitXor, test) {
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
// - IfNeStrictTOS; IfEqStrictTOS; IfNeStrictNumTOS; IfEqStrictNumTOS
//
// Skips the next instruction unless the given condition holds. 'Num'
« no previous file with comments | « runtime/lib/integers.cc ('k') | runtime/vm/constants_dbc.h » ('j') | runtime/vm/flow_graph_compiler_dbc.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698