runtime/lib/integers.cc - Issue 2053213004: DBC: Adds BinarySmiOp instruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/integers.cc

Issue 2053213004: DBC: Adds BinarySmiOp instruction (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments, fix bugs Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/integers.cc

diff --git a/runtime/lib/integers.cc b/runtime/lib/integers.cc

index 351cbbf6dd7cc39c353d256de23e79381449e8f0..5680037072af2ca8b15e1f1c6fffa2aa8208a08b 100644

--- a/runtime/lib/integers.cc

+++ b/runtime/lib/integers.cc

@@ -146,7 +146,7 @@ DEFINE_NATIVE_ENTRY(Integer_moduloFromInteger, 2) {

const Integer& right_int = Integer::CheckedHandle(arguments->NativeArgAt(0));

GET_NON_NULL_NATIVE_ARGUMENT(Integer, left_int, arguments->NativeArgAt(1));

ASSERT(CheckInteger(right_int));

- ASSERT(CheckInteger(right_int));

+ ASSERT(CheckInteger(left_int));

if (FLAG_trace_intrinsified_natives) {

OS::Print("Integer_moduloFromInteger %s mod %s\n",

left_int.ToCString(), right_int.ToCString());

« no previous file with comments | « no previous file | runtime/vm/assembler_dbc_test.cc » ('j') | runtime/vm/flow_graph_compiler_dbc.cc » ('J')