Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2053193002: cc : Move LayerImpl::children to test properties (Closed)

Created:
4 years, 6 months ago by jaydasika
Modified:
4 years, 6 months ago
Reviewers:
sunxd, ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Move LayerImpl::children to test properties BUG=602438 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff Cr-Commit-Position: refs/heads/master@{#399093}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -189 lines) Patch
M cc/layers/layer_impl.h View 3 chunks +1 line, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 4 chunks +8 lines, -9 lines 2 comments Download
M cc/layers/layer_impl_test_properties.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M cc/layers/layer_list_iterator.cc View 5 chunks +24 lines, -8 lines 0 comments Download
M cc/layers/layer_utils_unittest.cc View 2 chunks +20 lines, -12 lines 0 comments Download
M cc/layers/nine_patch_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M cc/layers/render_surface_impl_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M cc/layers/ui_resource_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/layer_tree_json_parser_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M cc/test/test_layer_tree_host_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 28 chunks +43 lines, -41 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 38 chunks +96 lines, -65 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 7 chunks +15 lines, -13 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 3 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jaydasika
More clean up :)
4 years, 6 months ago (2016-06-09 23:21:57 UTC) #4
ajuma
lgtm https://codereview.chromium.org/2053193002/diff/20001/cc/layers/layer_impl.cc File cc/layers/layer_impl.cc (right): https://codereview.chromium.org/2053193002/diff/20001/cc/layers/layer_impl.cc#newcode119 cc/layers/layer_impl.cc:119: } AddChild and RemoveChild should also (eventually) move ...
4 years, 6 months ago (2016-06-09 23:39:47 UTC) #5
jaydasika
https://codereview.chromium.org/2053193002/diff/20001/cc/layers/layer_impl.cc File cc/layers/layer_impl.cc (right): https://codereview.chromium.org/2053193002/diff/20001/cc/layers/layer_impl.cc#newcode119 cc/layers/layer_impl.cc:119: } On 2016/06/09 23:39:47, ajuma wrote: > AddChild and ...
4 years, 6 months ago (2016-06-10 02:13:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053193002/20001
4 years, 6 months ago (2016-06-10 02:14:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 04:34:35 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 04:35:45 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fc66cfb4ddd165a3d041c13eb73f46447b4762ff
Cr-Commit-Position: refs/heads/master@{#399093}

Powered by Google App Engine
This is Rietveld 408576698