Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: cc/layers/layer_utils_unittest.cc

Issue 2053193002: cc : Move LayerImpl::children to test properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer_utils_unittest.cc
diff --git a/cc/layers/layer_utils_unittest.cc b/cc/layers/layer_utils_unittest.cc
index 72f0bbee9b424c08852821f0a5dd193747d71eaa..dc6d4aea4625cd99e7c95833a08b772c438041fe 100644
--- a/cc/layers/layer_utils_unittest.cc
+++ b/cc/layers/layer_utils_unittest.cc
@@ -32,12 +32,12 @@ class LayerUtilsGetAnimationBoundsTest : public testing::Test {
&shared_bitmap_manager_,
&task_graph_runner_),
root_(CreateTwoForkTree(&host_impl_)),
- parent1_(root_->children()[0]),
- parent2_(root_->children()[1]),
- child1_(parent1_->children()[0]),
- child2_(parent2_->children()[0]),
- grand_child_(child2_->children()[0]),
- great_grand_child_(grand_child_->children()[0]) {
+ parent1_(root_->test_properties()->children[0]),
+ parent2_(root_->test_properties()->children[1]),
+ child1_(parent1_->test_properties()->children[0]),
+ child2_(parent2_->test_properties()->children[0]),
+ grand_child_(child2_->test_properties()->children[0]),
+ great_grand_child_(grand_child_->test_properties()->children[0]) {
timeline_ =
AnimationTimeline::Create(AnimationIdProvider::NextTimelineId());
host_impl_.animation_host()->AddAnimationTimeline(timeline_);
@@ -60,15 +60,23 @@ class LayerUtilsGetAnimationBoundsTest : public testing::Test {
LayerImpl::Create(host_impl->active_tree(), 1);
LayerImpl* root_ptr = root.get();
root->AddChild(LayerImpl::Create(host_impl->active_tree(), 2));
- root->children()[0]->AddChild(
+ root->test_properties()->children[0]->AddChild(
LayerImpl::Create(host_impl->active_tree(), 3));
root->AddChild(LayerImpl::Create(host_impl->active_tree(), 4));
- root->children()[1]->AddChild(
+ root->test_properties()->children[1]->AddChild(
LayerImpl::Create(host_impl->active_tree(), 5));
- root->children()[1]->children()[0]->AddChild(
- LayerImpl::Create(host_impl->active_tree(), 6));
- root->children()[1]->children()[0]->children()[0]->AddChild(
- LayerImpl::Create(host_impl->active_tree(), 7));
+ root->test_properties()
+ ->children[1]
+ ->test_properties()
+ ->children[0]
+ ->AddChild(LayerImpl::Create(host_impl->active_tree(), 6));
+ root->test_properties()
+ ->children[1]
+ ->test_properties()
+ ->children[0]
+ ->test_properties()
+ ->children[0]
+ ->AddChild(LayerImpl::Create(host_impl->active_tree(), 7));
host_impl->active_tree()->SetRootLayer(std::move(root));
return root_ptr;
}

Powered by Google App Engine
This is Rietveld 408576698