Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2053133003: Always post deletion of WebMediaPlayerMSCompositor. (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
qiangchen
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always post deletion of WebMediaPlayerMSCompositor. Another speculative fix to ensure that the provider is not deleted before the compositor is finished with it. BUG=595980 Committed: https://crrev.com/3ac77d9e4f412d02fc046fea304e9926ec01701b Cr-Commit-Position: refs/heads/master@{#399209}

Patch Set 1 #

Patch Set 2 : Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -43 lines) Patch
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 10 chunks +47 lines, -42 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
DaleCurtis
Crashes started right around M48, M49 so I think this is related to WebMediaPlayerMS somehow, ...
4 years, 6 months ago (2016-06-09 23:36:58 UTC) #3
qiangchen
lgtm
4 years, 6 months ago (2016-06-09 23:39:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053133003/1
4 years, 6 months ago (2016-06-09 23:41:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/174158)
4 years, 6 months ago (2016-06-10 00:06:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053133003/20001
4 years, 6 months ago (2016-06-10 00:17:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on ...
4 years, 6 months ago (2016-06-10 02:19:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053133003/20001
4 years, 6 months ago (2016-06-10 16:43:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 16:49:09 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 16:49:16 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 16:52:03 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ac77d9e4f412d02fc046fea304e9926ec01701b
Cr-Commit-Position: refs/heads/master@{#399209}

Powered by Google App Engine
This is Rietveld 408576698