content/renderer/media/webmediaplayer_ms.cc - Issue 2053133003: Always post deletion of WebMediaPlayerMSCompositor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_ms.cc

Issue 2053133003: Always post deletion of WebMediaPlayerMSCompositor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webmediaplayer_ms.cc

diff --git a/content/renderer/media/webmediaplayer_ms.cc b/content/renderer/media/webmediaplayer_ms.cc

index ef101d0cd340a50609a82a64e301e8fe55e8d7d8..a700fd56675837dd7a9e37ab44c7038439792835 100644

--- a/content/renderer/media/webmediaplayer_ms.cc

+++ b/content/renderer/media/webmediaplayer_ms.cc

@@ -84,7 +84,7 @@ WebMediaPlayerMS::~WebMediaPlayerMS() {

// Always do this before posting the |compositor_| for deletion.

get_client()->setWebLayer(nullptr);

- if (compositor_ && !compositor_task_runner_->BelongsToCurrentThread())

+ if (compositor_)

compositor_task_runner_->DeleteSoon(FROM_HERE, compositor_.release());

if (video_frame_provider_)

« no previous file with comments | « no previous file | content/renderer/media/webmediaplayer_ms_unittest.cc » ('j') | no next file with comments »