Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: fxjse/DEPS

Issue 2053043002: Untangle bad depdenency from fxjse/ to fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@move_fxjse
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/jsapi/include/fxjs_v8.h ('k') | fxjse/fxjs_perisolatedata.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fxjse/DEPS
diff --git a/fxjse/DEPS b/fxjse/DEPS
index 18698e4ce47b5693e93da6f1fe32d54aefb77d58..ccea0b552ad1aa84b15369dd69788d8ec81e6b15 100644
--- a/fxjse/DEPS
+++ b/fxjse/DEPS
@@ -1,6 +1,4 @@
include_rules = [
'+core/fxcrt/include',
- # TODO(dsinclair): Layering violation. FXJSE can't include FPDFSDK.
- '+fpdfsdk/jsapi/include',
'+v8/include',
]
« no previous file with comments | « fpdfsdk/jsapi/include/fxjs_v8.h ('k') | fxjse/fxjs_perisolatedata.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698