Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2052973002: Get Polymer externs from closure/github (instead of Polymer/bower) (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 6 months ago
Reviewers:
Jeremy Klein, fukino
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@roll-closure
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get Polymer externs from closure/github (instead of Polymer/bower) R=jlklein@chromium.org TBR=fukino@chromium.org # for trivial path change BUG=none Committed: https://crrev.com/f513e71e97c7e151d9f73c798253c18cbce075e4 Cr-Commit-Position: refs/heads/master@{#398991}

Patch Set 1 #

Patch Set 2 : revert binaries so we can try this thang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -1299 lines) Patch
M third_party/closure_compiler/compile.py View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/closure_compiler/compile2.py View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/closure_compiler/compiler_test.py View 1 chunk +1 line, -3 lines 0 comments Download
A + third_party/closure_compiler/externs/polymer-1.0.js View 12 chunks +129 lines, -34 lines 0 comments Download
M third_party/closure_compiler/roll_closure_compiler View 6 chunks +27 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/bower.json View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components-chromium/polymer-externs/polymer.externs.js View 1 chunk +0 lines, -1240 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Dan Beam
4 years, 6 months ago (2016-06-09 18:17:45 UTC) #1
Jeremy Klein
lgtm
4 years, 6 months ago (2016-06-09 18:25:31 UTC) #2
Dan Beam
TBR=fukino@ for path change in ui/file_manager land
4 years, 6 months ago (2016-06-09 19:08:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052973002/20001
4 years, 6 months ago (2016-06-09 19:09:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 20:10:53 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 20:12:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f513e71e97c7e151d9f73c798253c18cbce075e4
Cr-Commit-Position: refs/heads/master@{#398991}

Powered by Google App Engine
This is Rietveld 408576698