|
|
Created:
4 years, 6 months ago by caseq Modified:
4 years, 5 months ago CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClean up public TracingController interface
This removes trace endpoints from the content interface and moves them
to TracingControllerImpl. We don't want to expose both TraceDataSinks
and TraceEndpoints currently to avoid confusion.
Committed: https://crrev.com/2fe929b117ce9b37a5decf4dfa5fbc95f32b6ff2
Cr-Commit-Position: refs/heads/master@{#405272}
Patch Set 1 #Patch Set 2 : rebased #Patch Set 3 : rebased, added CONTENT_EXPORT where missing #
Messages
Total messages: 47 (28 generated)
The CQ bit was checked by caseq@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052773002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by caseq@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052773002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by caseq@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052773002/40001
The CQ bit was unchecked by caseq@chromium.org
The CQ bit was checked by caseq@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #3 (id:60001) has been deleted
The CQ bit was checked by caseq@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Clean up public TracingController interface This removes trace endpoints from the content interface and moves them to TracingControllerImpl. We don't want to expose both TraceDataSinks and TraceEndpoints currently to avoid confusion. BUG= ========== to ========== Clean up public TracingController interface This removes trace endpoints from the content interface and moves them to TracingControllerImpl. We don't want to expose both TraceDataSinks and TraceEndpoints currently to avoid confusion. ==========
caseq@chromium.org changed reviewers: + oysteine@chromium.org
Awesome! Thanks for this :). lgtm
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
caseq@chromium.org changed reviewers: + pfeldman@chromium.org
+pfeldman for content/public/browser
lgtm
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Clean up public TracingController interface This removes trace endpoints from the content interface and moves them to TracingControllerImpl. We don't want to expose both TraceDataSinks and TraceEndpoints currently to avoid confusion. ========== to ========== Clean up public TracingController interface This removes trace endpoints from the content interface and moves them to TracingControllerImpl. We don't want to expose both TraceDataSinks and TraceEndpoints currently to avoid confusion. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Clean up public TracingController interface This removes trace endpoints from the content interface and moves them to TracingControllerImpl. We don't want to expose both TraceDataSinks and TraceEndpoints currently to avoid confusion. ========== to ========== Clean up public TracingController interface This removes trace endpoints from the content interface and moves them to TracingControllerImpl. We don't want to expose both TraceDataSinks and TraceEndpoints currently to avoid confusion. Committed: https://crrev.com/2fe929b117ce9b37a5decf4dfa5fbc95f32b6ff2 Cr-Commit-Position: refs/heads/master@{#405272} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2fe929b117ce9b37a5decf4dfa5fbc95f32b6ff2 Cr-Commit-Position: refs/heads/master@{#405272} |