Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2052773002: Clean up public TracingController interface [1/3]: hide TraceDataEndpoint (Closed)

Created:
4 years, 6 months ago by caseq
Modified:
4 years, 5 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up public TracingController interface This removes trace endpoints from the content interface and moves them to TracingControllerImpl. We don't want to expose both TraceDataSinks and TraceEndpoints currently to avoid confusion. Committed: https://crrev.com/2fe929b117ce9b37a5decf4dfa5fbc95f32b6ff2 Cr-Commit-Position: refs/heads/master@{#405272}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased, added CONTENT_EXPORT where missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -57 lines) Patch
M content/browser/tracing/background_tracing_manager_impl.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 2 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl_data_sinks.cc View 2 8 chunks +13 lines, -15 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/tracing_controller.h View 2 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 47 (28 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052773002/20001
4 years, 6 months ago (2016-06-09 01:22:29 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/213550)
4 years, 6 months ago (2016-06-09 02:05:27 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052773002/1
4 years, 6 months ago (2016-06-09 06:42:32 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/150439)
4 years, 6 months ago (2016-06-09 06:51:02 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052773002/40001
4 years, 6 months ago (2016-06-09 06:54:40 UTC) #11
caseq
4 years, 5 months ago (2016-07-11 23:05:15 UTC) #24
oystein (OOO til 10th of July)
Awesome! Thanks for this :). lgtm
4 years, 5 months ago (2016-07-12 16:50:19 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2052773002/80001
4 years, 5 months ago (2016-07-12 17:56:40 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/216291)
4 years, 5 months ago (2016-07-12 18:11:13 UTC) #29
caseq
+pfeldman for content/public/browser
4 years, 5 months ago (2016-07-12 19:41:05 UTC) #31
pfeldman
lgtm
4 years, 5 months ago (2016-07-12 20:44:25 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2052773002/80001
4 years, 5 months ago (2016-07-12 21:16:23 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191833)
4 years, 5 months ago (2016-07-13 00:43:18 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2052773002/80001
4 years, 5 months ago (2016-07-13 01:09:30 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-13 02:11:16 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2052773002/80001
4 years, 5 months ago (2016-07-13 17:33:49 UTC) #42
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 5 months ago (2016-07-13 20:23:29 UTC) #44
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 20:24:29 UTC) #45
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:26:50 UTC) #47
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2fe929b117ce9b37a5decf4dfa5fbc95f32b6ff2
Cr-Commit-Position: refs/heads/master@{#405272}

Powered by Google App Engine
This is Rietveld 408576698