Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: content/public/browser/tracing_controller.h

Issue 2052773002: Clean up public TracingController interface [1/3]: hide TraceDataEndpoint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, added CONTENT_EXPORT where missing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/tracing_controller.h
diff --git a/content/public/browser/tracing_controller.h b/content/public/browser/tracing_controller.h
index 0de1a16b34c6ee8400055a8a6ef7d897ca544f9d..da44eeee684befef7635ce86edf84d6f2fbfbd08 100644
--- a/content/public/browser/tracing_controller.h
+++ b/content/public/browser/tracing_controller.h
@@ -74,50 +74,18 @@ class TracingController {
base::DictionaryValue metadata_;
};
- // An implementation of this interface is passed when constructing a
- // TraceDataSink, and receives chunks of the final trace data as it's being
- // constructed.
- // Methods may be called from any thread.
- class CONTENT_EXPORT TraceDataEndpoint
- : public base::RefCountedThreadSafe<TraceDataEndpoint> {
- public:
- virtual void ReceiveTraceChunk(const std::string& chunk) {}
- virtual void ReceiveTraceFinalContents(
- std::unique_ptr<const base::DictionaryValue> metadata,
- const std::string& contents) {}
-
- protected:
- friend class base::RefCountedThreadSafe<TraceDataEndpoint>;
- virtual ~TraceDataEndpoint() {}
- };
-
// Create a trace sink that may be supplied to StopTracing
// to capture the trace data as a string.
CONTENT_EXPORT static scoped_refptr<TraceDataSink> CreateStringSink(
const base::Callback<void(std::unique_ptr<const base::DictionaryValue>,
base::RefCountedString*)>& callback);
- CONTENT_EXPORT static scoped_refptr<TraceDataSink> CreateCompressedStringSink(
- scoped_refptr<TraceDataEndpoint> endpoint);
-
// Create a trace sink that may be supplied to StopTracing
// to dump the trace data to a file.
CONTENT_EXPORT static scoped_refptr<TraceDataSink> CreateFileSink(
const base::FilePath& file_path,
const base::Closure& callback);
- // Create an endpoint that may be supplied to any TraceDataSink to
- // dump the trace data to a callback.
- CONTENT_EXPORT static scoped_refptr<TraceDataEndpoint> CreateCallbackEndpoint(
- const base::Callback<void(std::unique_ptr<const base::DictionaryValue>,
- base::RefCountedString*)>& callback);
-
- // Create an endpoint that may be supplied to any TraceDataSink to
- // dump the trace data to a file.
- CONTENT_EXPORT static scoped_refptr<TraceDataEndpoint> CreateFileEndpoint(
- const base::FilePath& file_path,
- const base::Closure& callback);
-
// Get a set of category groups. The category groups can change as
// new code paths are reached.
//
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698