Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2052623002: [Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element. (Closed)

Created:
4 years, 6 months ago by whywhat
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-settings-npe
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element. Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site setting. Check the setting before allowing muted videos to autoplay. BUG=618083, 618081 TEST=Manual Committed: https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398 Cr-Commit-Position: refs/heads/master@{#399199}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Patch Set 3 : Rebased, added a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java View 2 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/autoplay-muted.html View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 chunks +15 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (9 generated)
whywhat
PTaL
4 years, 6 months ago (2016-06-08 20:38:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052623002/1
4 years, 6 months ago (2016-06-08 20:39:38 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/124379)
4 years, 6 months ago (2016-06-08 21:08:44 UTC) #6
Finnur
SiteSettingsPreferences.java LGTM. Mounir should probably bless the other file. One nit. https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.h File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right): ...
4 years, 6 months ago (2016-06-09 09:49:09 UTC) #7
mlamouri (slow - plz ping)
https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode3693 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3693: return true; I don't think that's okay. It will ...
4 years, 6 months ago (2016-06-09 11:15:08 UTC) #8
whywhat
Addressed comments
4 years, 6 months ago (2016-06-09 19:34:30 UTC) #9
whywhat
PTAL https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode3693 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3693: return true; On 2016/06/09 at 11:15:07, Mounir Lamouri ...
4 years, 6 months ago (2016-06-09 19:42:39 UTC) #10
mlamouri (slow - plz ping)
lgtm but this will need a rebase ;)
4 years, 6 months ago (2016-06-10 09:59:11 UTC) #11
whywhat
Rebased, added a test
4 years, 6 months ago (2016-06-10 12:09:10 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 2047333002 Patch 100001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-10 12:10:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052623002/40001
4 years, 6 months ago (2016-06-10 14:38:41 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-10 16:04:57 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 16:05:06 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 16:06:41 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398
Cr-Commit-Position: refs/heads/master@{#399199}

Powered by Google App Engine
This is Rietveld 408576698