[Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element.

[Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element.

Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site setting.

Check the setting before allowing muted videos to autoplay.

BUG=618083, 618081
TEST=Manual

Committed: https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398
Cr-Commit-Position: refs/heads/master@{#399199}

[whywhat, 2016-06-08 20:38:54]

avayvod@chromium.org changed reviewers:
+ finnur@chromium.org, mlamouri@chromium.org

[whywhat, 2016-06-08 20:38:54]

PTaL

[whywhat, 2016-06-08 20:39:01]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 20:39:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052623002/1

[commit-bot: I haz the power, 2016-06-08 21:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 21:08:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Finnur, 2016-06-09 09:49:09]

SiteSettingsPreferences.java LGTM. 
Mounir should probably bless the other file.
One nit.

https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:471: bool
isAutoplayAllowedPerSettings() const;
nit: Document.

[mlamouri (slow - plz ping), 2016-06-09 11:15:08]

https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3693: return true;
I don't think that's okay. It will allow content settings changes (like via
extensions) to block autoplay on desktop. I don't think we should do this quite
yet.

[whywhat, 2016-06-09 19:34:30]

Addressed comments

[whywhat, 2016-06-09 19:42:39]

PTAL

https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3693: return true;
On 2016/06/09 at 11:15:07, Mounir Lamouri (slow) wrote:
> I don't think that's okay. It will allow content settings changes (like via
extensions) to block autoplay on desktop. I don't think we should do this quite
yet.

Only check it after the check below.

https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2052623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:471: bool
isAutoplayAllowedPerSettings() const;
On 2016/06/09 at 09:49:09, Finnur wrote:
> nit: Document.

Done.

[mlamouri (slow - plz ping), 2016-06-10 09:59:11]

lgtm but this will need a rebase ;)

[whywhat, 2016-06-10 12:09:10]

Rebased, added a test

[whywhat, 2016-06-10 12:09:59]

Description was changed from

==========
[Android, Media] Enable autoplay settings for muted autoplay, wired them up to
the media element.

Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site
setting.

Check the setting before allowing muted videos to autoplay.

BUG=618083
TEST=Manual
==========

to

==========
[Android, Media] Enable autoplay settings for muted autoplay, wired them up to
the media element.

Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site
setting.

Check the setting before allowing muted videos to autoplay.

BUG=618083,618081
TEST=Manual
==========

[whywhat, 2016-06-10 12:10:11]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2016-06-10 12:10:11]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org,
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2052623002/#ps40001
(title: "Rebased, added a test")

[commit-bot: I haz the power, 2016-06-10 12:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 12:10:22]

This CL has an open dependency (Issue 2047333002 Patch 100001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[whywhat, 2016-06-10 14:38:29]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2016-06-10 14:38:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052623002/40001

[commit-bot: I haz the power, 2016-06-10 16:04:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-10 16:05:06]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 16:06:39]

Description was changed from

==========
[Android, Media] Enable autoplay settings for muted autoplay, wired them up to
the media element.

Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site
setting.

Check the setting before allowing muted videos to autoplay.

BUG=618083,618081
TEST=Manual
==========

to

==========
[Android, Media] Enable autoplay settings for muted autoplay, wired them up to
the media element.

Use chrome://flags/#enable-autoplay-muted-videos to enable the autoplay site
setting.

Check the setting before allowing muted videos to autoplay.

BUG=618083,618081
TEST=Manual

Committed: https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398
Cr-Commit-Position: refs/heads/master@{#399199}
==========

[commit-bot: I haz the power, 2016-06-10 16:06:41]

Patchset 3 (id:??) landed as
https://crrev.com/5d05e65d8ab098888e1e87cd51f93496e93a8398
Cr-Commit-Position: refs/heads/master@{#399199}