third_party/WebKit/LayoutTests/media/autoplay-muted.html - Issue 2052623002: [Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/autoplay-muted.html

Issue 2052623002: [Android, Media] Enable autoplay settings for muted autoplay, wired them up to the media element. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-settings-npe

Patch Set: Rebased, added a test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/autoplay-muted.html

diff --git a/third_party/WebKit/LayoutTests/media/autoplay-muted.html b/third_party/WebKit/LayoutTests/media/autoplay-muted.html

index bd83ef15f90ecaae5e2f62d522701319693ebc67..e0b5926b5d75ddd2587fc0b5ba9caa570f8af721 100644

--- a/third_party/WebKit/LayoutTests/media/autoplay-muted.html

+++ b/third_party/WebKit/LayoutTests/media/autoplay-muted.html

@@ -15,6 +15,7 @@

window.internals.settings.setMediaPlaybackRequiresUserGesture(true);

window.internals.runtimeFlags.autoplayMutedVideosEnabled = true;

+ testRunner.setAutoplayAllowed(true);

function createMutedVideoElement() {

var e = document.createElement('video');

@@ -60,4 +61,14 @@

assert_false(e.paused, "The video should not be paused.");

});

}, "Test that unmuting autoplayed video with gesture doesn't pause it.");

+ promise_test(function(t) {

+ testRunner.setAutoplayAllowed(false);

+ return promise_rejects(

+ t,

+ new DOMException(

+ 'play() can only be initiated by a user gesture.',

+ 'NotAllowedError'),

+ createMutedVideoElement().play());

+ }, "Test that muted videos don't autoplay when the setting is disabled");

</script>