Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2052603002: Restore calls to MessageLoopForUI::current in chrome/. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews, asanka, msramek+watch_chromium.org, skanuj+watch_chromium.org, sadrul, oshima+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, dcheng, rginda+watch_chromium.org, noyau+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, tapted, cbentzel+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, grt+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, rlp+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, vabr+watchlistpasswordmanager_chromium.org, extensions-reviews_chromium.org, dkrahn+watch_chromium.org, media-router+watch_chromium.org, jfweitz+watch_chromium.org, rouslan+spell_chromium.org, asvitkine+watch_chromium.org, kalyank, gcasto+watchlist_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, michaelpg+watch-options_chromium.org, tfarina, donnd+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore calls to MessageLoopForUI::current() in chrome/. Some calls to MessageLoopForUI::current()->PostTask/DeleteSoon were wrongly migrated to ThreadTaskRunnerHandle::Get() by https://codereview.chromium.org/2033753002/ (see discussion at https://groups.google.com/a/chromium.org/d/msg/chromium-dev/Wj_cNO2l2qE/1XWt_Ex1AgAJ) This CL migrates these calls to MessageLoopForUI::current()->task_runner()->PostTask/DeleteSoon instead. BUG=616447 Committed: https://crrev.com/6be72adffd58d7b87f47ab6ea69e1985e808f272 Cr-Commit-Position: refs/heads/master@{#400194}

Patch Set 1 : revert https://codereview.chromium.org/2033753002/ #

Patch Set 2 : restore calls to MessageLoopForUI::current() #

Patch Set 3 : restore calls to MessageLoopForUI::current() #

Patch Set 4 : migrate MessageLoopForUI::current() to MessageLoopForUI::current()->task_runner() #

Patch Set 5 : add missing includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_reauth.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/media_delegate_chromeos.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-08 20:32:00 UTC) #3
fdoray
+sky@: Can you review this CL? (Nico traveling)
4 years, 6 months ago (2016-06-15 17:17:45 UTC) #5
sky
LGTM
4 years, 6 months ago (2016-06-16 16:17:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052603002/80001
4 years, 6 months ago (2016-06-16 16:20:46 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-16 17:46:56 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 17:48:20 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6be72adffd58d7b87f47ab6ea69e1985e808f272
Cr-Commit-Position: refs/heads/master@{#400194}

Powered by Google App Engine
This is Rietveld 408576698