chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc - Issue 2052603002: Restore calls to MessageLoopForUI::current in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc

Issue 2052603002: Restore calls to MessageLoopForUI::current in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missing includes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc ('k') | chrome/browser/ui/ash/media_delegate_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc

diff --git a/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc b/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc

index cc37471fbddcb7aa329bbc99fec6656582455523..e5ff19442a5cc782e65111196e834ea117693ce8 100644

--- a/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc

+++ b/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc

@@ -9,8 +9,8 @@

#include "base/location.h"

#include "base/logging.h"

#include "base/macros.h"

+#include "base/message_loop/message_loop.h"

#include "base/single_thread_task_runner.h"

-#include "base/threading/thread_task_runner_handle.h"

#include "chrome/browser/chromeos/login/login_manager_test.h"

#include "chrome/browser/chromeos/login/screens/error_screen.h"

#include "chrome/browser/chromeos/login/screens/network_error_view.h"

@@ -93,7 +93,8 @@ class CaptivePortalWindowTest : public InProcessBrowserTest {

void TearDownOnMainThread() override {

captive_portal_window_proxy_.reset();

- base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, host_);

+ base::MessageLoopForUI::current()->task_runner()->DeleteSoon(FROM_HERE,

+ host_);

base::MessageLoopForUI::current()->RunUntilIdle();

}