Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2052543003: Emit CURRENT_TIMESTAMP annotation (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
git@github.com:luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

Emit CURRENT_TIMESTAMP annotation Add --timestamps flag. If specified (default: false), emit CURRENT_TIMESTAMP annotations. See --timestamps flag help for more. R=martiniss@chromium.org, iannucci@chromium.org BUG=613584 Committed: https://github.com/luci/recipes-py/commit/02bd5642786bd00b6060404bf8c459e6cc146c4c

Patch Set 1 #

Patch Set 2 : fixed tests #

Patch Set 3 : nit #

Patch Set 4 : in the beginning and end too #

Patch Set 5 : beginning and end #

Patch Set 6 : --timestamps flag #

Patch Set 7 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -75 lines) Patch
M recipe_engine/simulation_test.py View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M recipe_engine/stream.py View 1 2 3 4 5 6 9 chunks +52 lines, -5 lines 0 comments Download
M recipe_engine/unittests/run_test.py View 1 2 3 4 5 1 chunk +17 lines, -17 lines 0 comments Download
M recipe_engine/unittests/stream_test.py View 1 2 3 4 5 2 chunks +48 lines, -31 lines 0 comments Download
M recipes.py View 1 2 3 4 5 2 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nodir
PTAL
4 years, 6 months ago (2016-06-08 21:37:33 UTC) #1
nodir
ping
4 years, 6 months ago (2016-06-09 17:01:00 UTC) #2
nodir
in next patchset I will add CURRENT_TIMESTAMP in the beginning and very end
4 years, 6 months ago (2016-06-09 18:09:30 UTC) #3
martiniss
lgtm
4 years, 6 months ago (2016-06-10 00:50:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052543003/140001
4 years, 6 months ago (2016-06-10 01:47:30 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 01:49:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #7 (id:140001) as
https://github.com/luci/recipes-py/commit/02bd5642786bd00b6060404bf8c459e6cc1...

Powered by Google App Engine
This is Rietveld 408576698