Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2050703003: Add CURRENT_TIMESTAMP annotation (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add CURRENT_TIMESTAMP annotation - ignore (do not complain) CURRENT_TIMESTAMP annotation when received by AnnotationObserver - emit CURRENT_TIMESTAMP in StructuredAnnotationStep just for consistency. The annotations that we actually care about will be emitted by recipe engine R=iannucci@chromium.org, martiniss@chromium.org BUG=613584

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M scripts/common/annotator.py View 1 2 6 chunks +18 lines, -2 lines 0 comments Download
M scripts/common/unittests/annotator_test.py View 6 chunks +13 lines, -3 lines 0 comments Download
M scripts/master/chromium_step.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nodir
PTAL Tested locally. Example output: https://gist.github.com/nodirt/812bc47394dc75e12b43159f9b72e8e8 https://codereview.chromium.org/2050703003/diff/20001/scripts/common/annotator.py File scripts/common/annotator.py (right): https://codereview.chromium.org/2050703003/diff/20001/scripts/common/annotator.py#newcode274 scripts/common/annotator.py:274: self.current_timestamp(self.time_fn()) current_timestamp method ...
4 years, 6 months ago (2016-06-08 17:42:23 UTC) #1
nodir
ping
4 years, 6 months ago (2016-06-09 17:02:22 UTC) #2
martiniss
lgtm
4 years, 6 months ago (2016-06-09 18:46:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050703003/40001
4 years, 6 months ago (2016-06-09 18:52:32 UTC) #5
nodir
4 years, 6 months ago (2016-06-10 17:04:45 UTC) #7
Message was sent while issue was closed. 
closed this CL because it would require restarting all masters. Instead we can
emit timestamps only on swarming

Powered by Google App Engine
This is Rietveld 408576698