chrome/browser/spellchecker/feedback_sender.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/feedback_sender.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_engine_extension_api.cc ('k') | chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/feedback_sender.cc

diff --git a/chrome/browser/spellchecker/feedback_sender.cc b/chrome/browser/spellchecker/feedback_sender.cc

index aa2eb756bee816d8e5099b9205878acac8c8b26d..879358d575b6226396b0cb5257fd0ee08c26cc5c 100644

--- a/chrome/browser/spellchecker/feedback_sender.cc

+++ b/chrome/browser/spellchecker/feedback_sender.cc

@@ -31,6 +31,7 @@

#include <algorithm>

#include <iterator>

+#include <utility>

#include "base/command_line.h"

#include "base/hash.h"

@@ -134,7 +135,7 @@ std::unique_ptr<base::ListValue> BuildSuggestionInfo(

base::Uint64ToString(BuildAnonymousHash(salt, suggestion)));

}

misspelling->Set("userSuggestionId", suggestion_list.release());

- list->Append(misspelling.release());

+ list->Append(std::move(misspelling));

}

return list;

}