chrome/browser/extensions/api/management/management_api_unittest.cc - Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api_unittest.cc

Issue 2051663003: base::ListValue::Append cleanup: pass unique_ptr instead of the released pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_api.cc ('k') | chrome/browser/extensions/api/media_galleries/media_galleries_api.cc » ('j') | extensions/browser/api/declarative/rules_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api_unittest.cc

diff --git a/chrome/browser/extensions/api/management/management_api_unittest.cc b/chrome/browser/extensions/api/management/management_api_unittest.cc

index 8c0fad4cef66fd4bf67d6b1f40e99008a848c0c8..9fd8a426b00b05198170593efb0646c7a94954ec 100644

--- a/chrome/browser/extensions/api/management/management_api_unittest.cc

+++ b/chrome/browser/extensions/api/management/management_api_unittest.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include <memory>

+#include <utility>

#include "base/macros.h"

#include "base/memory/ptr_util.h"

@@ -197,7 +198,7 @@ TEST_F(ManagementApiUnitTest, ManagementUninstall) {

// Try again, using showConfirmDialog: false.

std::unique_ptr<base::DictionaryValue> options(new base::DictionaryValue());

options->SetBoolean("showConfirmDialog", false);

- uninstall_args.Append(options.release());

+ uninstall_args.Append(std::move(options));

function = new ManagementUninstallFunction();

EXPECT_TRUE(registry()->enabled_extensions().Contains(extension_id));

EXPECT_FALSE(RunFunction(function, uninstall_args));