Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2051503002:
Fix restore windows chrome icon has no running status bar on shelf (Closed)
|
Created:
4 years, 6 months ago by Qiang(Joe) Xu Modified:
4 years, 6 months ago Reviewers:
stevenjb CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix restore windows chrome icon has no running status bar on shelf
The edge case in crbug/616179 happens when browser window is not active, which means browser_list->begin_last_active() to end_last_active() cannot track it.
BUG=616179
TEST=manually test sees bug fixed
Committed: https://crrev.com/0f5c5f44fbaf89a0b53c95adc55264362624811a
Cr-Commit-Position: refs/heads/master@{#398695}
Patch Set 1 #Patch Set 2 : fix unittest failure #
Total comments: 1
Patch Set 3 : using c++11 range iterator #
Messages
Total messages: 25 (12 generated)
Description was changed from ========== Fix restore windows chrome icon has no running status bar on shelf BUG=616179 TEST=manually test sees bug fixed ========== to ========== Fix restore windows chrome icon has no running status bar on shelf The edge case in crbug/616179 happens when browser window is not active, which means browser_list->begin_last_active() to end_last_active() cannot track it. BUG=616179 TEST=manually test sees bug fixed ==========
warx@chromium.org changed reviewers: + stevenjb@chromium.org
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051503002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051503002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051503002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Steven, could you help review on this? tks
https://codereview.chromium.org/2051503002/diff/40001/chrome/browser/ui/ash/l... File chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc (right): https://codereview.chromium.org/2051503002/diff/40001/chrome/browser/ui/ash/l... chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc:108: ++it) { As long as we are cleaning this up, can we just use a c++11 iterator and break when we set browser_status = RUNNING?
On 2016/06/08 20:06:44, stevenjb wrote: > https://codereview.chromium.org/2051503002/diff/40001/chrome/browser/ui/ash/l... > File chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc > (right): > > https://codereview.chromium.org/2051503002/diff/40001/chrome/browser/ui/ash/l... > chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc:108: > ++it) { > As long as we are cleaning this up, can we just use a c++11 iterator and break > when we set browser_status = RUNNING? Sure. Done. tks.
lgtm
The CQ bit was checked by warx@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051503002/60001
Message was sent while issue was closed.
Description was changed from ========== Fix restore windows chrome icon has no running status bar on shelf The edge case in crbug/616179 happens when browser window is not active, which means browser_list->begin_last_active() to end_last_active() cannot track it. BUG=616179 TEST=manually test sees bug fixed ========== to ========== Fix restore windows chrome icon has no running status bar on shelf The edge case in crbug/616179 happens when browser window is not active, which means browser_list->begin_last_active() to end_last_active() cannot track it. BUG=616179 TEST=manually test sees bug fixed ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix restore windows chrome icon has no running status bar on shelf The edge case in crbug/616179 happens when browser window is not active, which means browser_list->begin_last_active() to end_last_active() cannot track it. BUG=616179 TEST=manually test sees bug fixed ========== to ========== Fix restore windows chrome icon has no running status bar on shelf The edge case in crbug/616179 happens when browser window is not active, which means browser_list->begin_last_active() to end_last_active() cannot track it. BUG=616179 TEST=manually test sees bug fixed Committed: https://crrev.com/0f5c5f44fbaf89a0b53c95adc55264362624811a Cr-Commit-Position: refs/heads/master@{#398695} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0f5c5f44fbaf89a0b53c95adc55264362624811a Cr-Commit-Position: refs/heads/master@{#398695} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
