Fix restore windows chrome icon has no running status bar on shelf

chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h"
 
 #include <vector>
 
 #include "ash/shelf/shelf_model.h"
 #include "ash/shelf/shelf_util.h"
@@ skipping 85 matching lines @@
           browser->tab_strip_model()->GetActiveWebContents();
       if (contents &&
           (launcher_controller()->GetShelfIDForWebContents(contents) !=
               browser_item.id))
         browser_status = ash::STATUS_RUNNING;
     }
   }
 
   if (browser_status == ash::STATUS_CLOSED) {
     const BrowserList* browser_list = BrowserList::GetInstance();
-    for (BrowserList::const_reverse_iterator it =
-             browser_list->begin_last_active();
-         it != browser_list->end_last_active() &&
-         browser_status == ash::STATUS_CLOSED;
+    for (BrowserList::const_iterator it = browser_list->begin();
+         it != browser_list->end() && browser_status == ash::STATUS_CLOSED;
          ++it) {

[stevenjb, 2016/06/08 20:06:43]

As long as we are cleaning this up, can we just use a c++11 iterator and break
when we set browser_status = RUNNING?

       if (IsBrowserRepresentedInBrowserList(*it))
         browser_status = ash::STATUS_RUNNING;
     }
   }
 
   if (browser_status != browser_item.status) {
     browser_item.status = browser_status;
     model->Set(browser_index, browser_item);
   }
 }
@@ skipping 244 matching lines @@
         !browser->window()->IsMinimized()) {
       continue;
     }
     if (!IsBrowserRepresentedInBrowserList(browser) &&
         !browser->is_type_tabbed())
       continue;
     active_browsers.push_back(browser);
   }
   return active_browsers;
 }