Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2051443003: [turbofan] Remove threading of FrameStateBeforeAndAfter. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove threading of FrameStateBeforeAndAfter. This removes the by now obsolete threading of the helper class attaching two frame states (before and after) to a given node. This helper is no longer required for variable loads and stores. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/2822d2df4003e2e763bea0880db2722f64cefd1a Cr-Commit-Position: refs/heads/master@{#36829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -48 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 24 chunks +35 lines, -45 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-08 13:15:34 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-06-08 14:49:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051443003/1
4 years, 6 months ago (2016-06-08 14:53:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 14:55:29 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 14:55:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2822d2df4003e2e763bea0880db2722f64cefd1a
Cr-Commit-Position: refs/heads/master@{#36829}

Powered by Google App Engine
This is Rietveld 408576698