Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2050673002: [turbofan] Limit use of FrameStateBeforeAndAfter helper. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-graph-builder-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Limit use of FrameStateBeforeAndAfter helper. This limits the use of the aforementioned helper class to only binary and compare operations. These are the only operatins left that require two frame state inputs on the same node. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/ed90142fc2a87b7e019371c43960f251127c2b7a Cr-Commit-Position: refs/heads/master@{#36832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -105 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +8 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 40 chunks +108 lines, -104 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-08 14:31:45 UTC) #1
Jarin
lgtm. Thanks!
4 years, 6 months ago (2016-06-08 14:46:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050673002/1
4 years, 6 months ago (2016-06-08 15:36:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 15:38:05 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 15:39:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed90142fc2a87b7e019371c43960f251127c2b7a
Cr-Commit-Position: refs/heads/master@{#36832}

Powered by Google App Engine
This is Rietveld 408576698