[interpreter] support async functions in Ignition

src/globals.h

Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index f4e09dd59fd5e0a76574c2cf103077d505c51954..d23b2e3c3bfaaa7ca91c9ea1c19d4eac6f3b37a9 100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -1024,6 +1024,10 @@ inline bool IsAsyncFunction(FunctionKind kind) {
   return kind & FunctionKind::kAsyncFunction;
 }
 
+inline bool IsResumableFunction(FunctionKind kind) {
+  return IsGeneratorFunction(kind) || IsAsyncFunction(kind);

[Benedikt Meurer, 2016/06/13 17:13:47]

I'm really not sure this helper function adds to the overall readability, as
that is yet another term to remember. I'd prefer to have just
IsGeneratorFunction(kind)||IsAsyncFunction(kind) whenever something applies to
both, that makes it immediately obvious that the particular code applies to both
generators and async functions w/o having to lookup what a "resumable function"
might be. Plus it makes it easier to spot code related to async function by just
grepping for AsyncFunction.

But I see that this "resumable" predicate is already being used in other places.
So fine for this CL, but maybe we can have a cleanup CL afterwards to remove the
"resumable" terminology and explicitly say "generator" and "async function"
instead?

[caitp (gmail), 2016/06/13 17:17:32]

I generally agree, but it is sort of mixed messaging between different
reviewers. If this sort of pattern comes up in the future, there should probably
be project-wide guidelines for it

+}
+
 inline bool IsConciseMethod(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kConciseMethod;