[interpreter] support async functions in Ignition

src/globals.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_GLOBALS_H_
 #define V8_GLOBALS_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 1006 matching lines @@
 inline bool IsGeneratorFunction(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kGeneratorFunction;
 }
 
 inline bool IsAsyncFunction(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kAsyncFunction;
 }
 
+inline bool IsResumableFunction(FunctionKind kind) {
+  return IsGeneratorFunction(kind) || IsAsyncFunction(kind);

[Benedikt Meurer, 2016/06/13 17:13:47]

I'm really not sure this helper function adds to the overall readability, as
that is yet another term to remember. I'd prefer to have just
IsGeneratorFunction(kind)||IsAsyncFunction(kind) whenever something applies to
both, that makes it immediately obvious that the particular code applies to both
generators and async functions w/o having to lookup what a "resumable function"
might be. Plus it makes it easier to spot code related to async function by just
grepping for AsyncFunction.

But I see that this "resumable" predicate is already being used in other places.
So fine for this CL, but maybe we can have a cleanup CL afterwards to remove the
"resumable" terminology and explicitly say "generator" and "async function"
instead?

[caitp (gmail), 2016/06/13 17:17:32]

I generally agree, but it is sort of mixed messaging between different
reviewers. If this sort of pattern comes up in the future, there should probably
be project-wide guidelines for it

+}
+
 inline bool IsConciseMethod(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kConciseMethod;
 }
 
 inline bool IsGetterFunction(FunctionKind kind) {
   DCHECK(IsValidFunctionKind(kind));
   return kind & FunctionKind::kGetterFunction;
 }
 
@@ skipping 48 matching lines @@
   return static_cast<uint32_t>(bit_cast<uintptr_t>(address) >>
                                kPointerSizeLog2);
 }
 
 }  // namespace internal
 }  // namespace v8
 
 namespace i = v8::internal;
 
 #endif  // V8_GLOBALS_H_