Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2051373002: Rewrite and organize tests in LayoutTests/shadow-dom (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean-test2-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite and organize tests in LayoutTests/shadow-dom To separate our concerns, move some tests to LayoutTests/shadow-dom/v0 directory if they are also testing v0 features for compatibility reasons. In summary: - LayoutTests/shadow-dom/ Used for tests if they are testing only v1 features - LayoutTests/shadow-dom/v0/ Used for tests if they are also testing v0 featuers Clean up is not finished. Other clean up CLs will come later. BUG=531990 Committed: https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7 Cr-Commit-Position: refs/heads/master@{#399127}

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 3

Patch Set 3 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -733 lines) Patch
D third_party/WebKit/LayoutTests/shadow-dom/cascade-deep-in-v1.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-deep-in-v1-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/default-slots.html View 1 chunk +0 lines, -43 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html View 1 2 1 chunk +99 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-deep-path.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-deep-path-empty.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot.html View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot-expected.txt View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot2.html View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot2-expected.txt View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html View 1 2 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points-re-distribution.html View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points-re-distribution-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/multiple-shadowroot-with-params.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/multiple-shadowroot-with-params-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js View 1 2 2 chunks +27 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-api-in-v0.html View 1 chunk +0 lines, -41 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/slots-default-slot.html View 1 chunk +40 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-in-v0.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slots-in-v0-expected.html View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/v0-inert-features-in-v1-shadow-trees.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/cascade-deep-in-v1-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path.html View 1 chunk +28 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/get-destination-insertion-points-re-distribution-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/multiple-shadowroot-with-params.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/multiple-shadowroot-with-params-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/slots-api-in-v0.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/slots-in-v0.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/slots-in-v0-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/v0-inert-features-in-v1-shadow-trees.html View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051373002/1
4 years, 6 months ago (2016-06-10 03:56:01 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/19246) ios-device-gn on ...
4 years, 6 months ago (2016-06-10 03:58:35 UTC) #4
hayato
rebased
4 years, 6 months ago (2016-06-10 04:34:04 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051373002/20001
4 years, 6 months ago (2016-06-10 04:34:27 UTC) #9
hayato
PTAL
4 years, 6 months ago (2016-06-10 04:34:49 UTC) #11
kochi
https://codereview.chromium.org/2051373002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html File third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html (right): https://codereview.chromium.org/2051373002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html#newcode2 third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html:2: <script src="../../resources/js-test.js"></script> Are you moving all tests that use ...
4 years, 6 months ago (2016-06-10 04:43:39 UTC) #12
hayato
https://codereview.chromium.org/2051373002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html File third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html (right): https://codereview.chromium.org/2051373002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html#newcode2 third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html:2: <script src="../../resources/js-test.js"></script> On 2016/06/10 at 04:43:39, kochi wrote: > ...
4 years, 6 months ago (2016-06-10 04:52:09 UTC) #13
hayato
The current patch set is not clean, I think. Let me upload another patch set.
4 years, 6 months ago (2016-06-10 04:57:24 UTC) #14
kochi
will wait for the next patch set. https://codereview.chromium.org/2051373002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html File third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html (right): https://codereview.chromium.org/2051373002/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html#newcode2 third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path-closed-shadowroot2.html:2: <script src="../../resources/js-test.js"></script> ...
4 years, 6 months ago (2016-06-10 05:01:47 UTC) #15
hayato
clean up
4 years, 6 months ago (2016-06-10 05:37:04 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051373002/40001
4 years, 6 months ago (2016-06-10 05:37:07 UTC) #18
hayato
Uploaded. PTAL. To make the patch smaller, I'll continue clean up in another CL.
4 years, 6 months ago (2016-06-10 05:39:03 UTC) #19
kochi
lgtm
4 years, 6 months ago (2016-06-10 05:46:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051373002/40001
4 years, 6 months ago (2016-06-10 06:39:31 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-10 06:55:32 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 06:57:13 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/05dfeece047ff46aa141f167598e2ec8b3cb3da7
Cr-Commit-Position: refs/heads/master@{#399127}

Powered by Google App Engine
This is Rietveld 408576698