ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc - Issue 2051343002: Make various gfx classes more amenable to use as compile-time constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc

Issue 2051343002: Make various gfx classes more amenable to use as compile-time constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile and test fixes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc

diff --git a/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc b/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc

index 34bffbb872aa86d48a00a587821af5d0ec92ff83..574e7815926d7a87debd1ab57957a4bc742db5fc 100644

--- a/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc

+++ b/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc

@@ -63,7 +63,6 @@ void VirtualKeyboardTray::SetShelfAlignment(ShelfAlignment alignment) {

// vertically aligned as the button would violate the width constraint on the

// shelf.

if (IsHorizontalAlignment(alignment)) {

- gfx::Insets insets = button_->GetInsets();

int additional_padding = std::max(0, top_padding - left_padding);

left_padding += additional_padding;

right_padding += additional_padding;

« no previous file with comments | « ash/magnifier/magnification_controller.cc ('k') | ash/touch/touch_transformer_controller.cc » ('j') | cc/trees/occlusion_tracker_perftest.cc » ('J')