ash/magnifier/magnification_controller.cc - Issue 2051343002: Make various gfx classes more amenable to use as compile-time constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/magnifier/magnification_controller.cc

Issue 2051343002: Make various gfx classes more amenable to use as compile-time constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile and test fixes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/common/wm/dock/docked_window_layout_manager.cc ('k') | ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc » ('j') | cc/trees/occlusion_tracker_perftest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/magnifier/magnification_controller.cc

diff --git a/ash/magnifier/magnification_controller.cc b/ash/magnifier/magnification_controller.cc

index 1c812d793647681998f9da600fcd82323526649c..04503cad12ea93c586601a81502c901ef3b2310c 100644

--- a/ash/magnifier/magnification_controller.cc

+++ b/ash/magnifier/magnification_controller.cc

@@ -770,7 +770,6 @@ void MagnificationControllerImpl::MoveMagnifierWindowFollowRect(

const int left = viewport_rect.x();

const int right = viewport_rect.right();

const gfx::Point rect_center = rect.CenterPoint();

- const gfx::Point window_center = viewport_rect.CenterPoint();

int x = left;

if (rect.x() < left || right < rect.right()) {