content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h - Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address new review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc ('k') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

index 1ab6e0cf601645a42fbd5ea55487707c7faff05c..0b960cfe4c732dc89af7b89cc5dca43d9c36ad12 100644

--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

@@ -700,7 +700,8 @@ class LayoutTestBluetoothAdapterProvider {

// Stops calling GattCharacteristicValueChanged and runs callback.

static std::unique_ptr<

testing::NiceMock<device::MockBluetoothGattNotifySession>>

- GetBaseGATTNotifySession(const std::string& characteristic_identifier);

+ GetBaseGATTNotifySession(

+ base::WeakPtr<device::BluetoothRemoteGattCharacteristic> characteristic);

// Helper functions: