components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc - Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

Issue 2051333004: Implement BluetoothGattNotifySession::Stop on Android, 2nd attempt (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address new review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/ble/bluetooth_low_energy_connection_unittest.cc ('k') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

diff --git a/components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc b/components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

index 476de39a8fd4e1ecb8752bebbe57b12f1bdc0a14..3ea9afa207d9fdc27ff5b677ba7347e068fd547c 100644

--- a/components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

+++ b/components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc

@@ -486,7 +486,7 @@ class ProximityAuthBluetoothLowEnergyWeaveClientConnectionTest

// Store an alias for the notify session passed |connection|.

std::unique_ptr<device::MockBluetoothGattNotifySession> notify_session(

new NiceMock<device::MockBluetoothGattNotifySession>(

- kTXCharacteristicID));

+ tx_characteristic_->GetWeakPtr()));

notify_session_alias_ = notify_session.get();

notify_session_success_callback_.Run(std::move(notify_session));