Fix GrShape to preserve inverseness of rrects for strokes but not dashes.

src/gpu/GrShape.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrShape.h"
 
 GrShape& GrShape::operator=(const GrShape& that) {
@@ skipping 263 matching lines @@
         SkAssertResult(parent.fStyle.applyToPath(fPath.get(), &fillOrHairline, *srcForParentStyle,
                                                  scale));
         fStyle.resetToInitStyle(fillOrHairline);
     }
     this->attemptToReduceFromPath();
     this->setInheritedKey(*parentForKey, apply, scale);
 }
 
 static inline bool rrect_path_is_inverse_filled(const SkPath& path, const SkStrokeRec& strokeRec,
                                                 const SkPathEffect* pe) {
-    // Dashing doesn't use the path fill type. Dashing only works with stroking
+    // This is currently imitating the questionable behavior of the sw-rasterizer. Inverseness is
+    // respected for stroking but not dashing + stroking. (We make no assumptions about arbitrary
+    // path effects and preserve the path's inverseness.)
+    // skbug.com/5421
     if (pe && pe->asADash(nullptr)) {
-        pe = nullptr;
+        SkDEBUGCODE(SkStrokeRec::Style style = strokeRec.getStyle();)
+        SkASSERT(SkStrokeRec::kStroke_Style == style || SkStrokeRec::kHairline_Style == style);
+        return false;
     }
 
-    SkStrokeRec::Style style = strokeRec.getStyle();
-    if (!pe && (SkStrokeRec::kStroke_Style == style || SkStrokeRec::kHairline_Style == style)) {
-        // stroking ignores the path fill rule.
-        return false;
-    }
     return path.isInverseFillType();
 }
 
 GrShape::Type GrShape::AttemptToReduceFromPathImpl(const SkPath& path, SkRRect* rrect,
                                                    SkPath::Direction* rrectDir,
                                                    unsigned* rrectStart,
                                                    bool* rrectIsInverted,
                                                    const SkPathEffect* pe,
                                                    const SkStrokeRec& strokeRec) {
     if (path.isEmpty()) {
@@ skipping 45 matching lines @@
                 // Since there is no path effect the dir and start index is immaterial.
                 *rrectDir = kDefaultRRectDir;
                 *rrectStart = kDefaultRRectStart;
                 *rrectIsInverted = rrect_path_is_inverse_filled(path, strokeRec, pe);
                 return Type::kRRect;
             }
         }
     }
     return Type::kPath;
 }