Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2051113002: [stubs] ToNumberStub --> ToNumber builtin. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] ToNumberStub --> ToNumber builtin. This makes sure we do not compile ToNumber stub on demand. This makes it easier to use during concurrent compilation. Committed: https://crrev.com/406146ff5ca274265ee704d73a00c8a8127f75c6 Cr-Commit-Position: refs/heads/master@{#36870}

Patch Set 1 #

Patch Set 2 : Fix full-code on non-x64 platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -443 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +41 lines, -8 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 5 chunks +51 lines, -8 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M src/builtins.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/code-stubs.h View 3 chunks +0 lines, -21 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 5 chunks +50 lines, -8 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M src/mips/builtins-mips.cc View 4 chunks +51 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 4 chunks +51 lines, -8 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 4 chunks +43 lines, -8 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +51 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +0 lines, -45 lines 0 comments Download
M src/x87/builtins-x87.cc View 5 chunks +50 lines, -8 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-06-09 13:32:37 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-09 15:33:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051113002/20001
4 years, 6 months ago (2016-06-09 15:33:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 15:36:19 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 15:38:30 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/406146ff5ca274265ee704d73a00c8a8127f75c6
Cr-Commit-Position: refs/heads/master@{#36870}

Powered by Google App Engine
This is Rietveld 408576698