src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2051113002: [stubs] ToNumberStub --> ToNumber builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2051113002: [stubs] ToNumberStub --> ToNumber builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix full-code on non-x64 platforms Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index aa35e49f605a0aa32761336ce4792cb660afe1eb..6fb4c8a9baceb087ffc03dbcda57f32361f2c571 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -3230,8 +3230,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {

}

// Convert old value into a number.

- ToNumberStub convert_stub(isolate());

- __ CallStub(&convert_stub);

+ __ Call(isolate()->builtins()->ToNumber(), RelocInfo::CODE_TARGET);

PrepareForBailoutForId(expr->ToNumberId(), BailoutState::TOS_REGISTER);

// Save result for postfix expressions.