Remove more dead code now that legacy const is gone

Remove more dead code now that legacy const is gone

Neither globals nor lookup slots can be hole-initialized anymore, thus
removing some dead code from the code generators and runtime-scopes.

Committed: https://crrev.com/757221e574ecba543a65f4822c083aa860e030eb
Cr-Commit-Position: refs/heads/master@{#36876}

[adamk, 2016-06-09 15:36:56]

adamk@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-06-09 16:10:33]

LGTM.

https://codereview.chromium.org/2051073004/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2051073004/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1134: case VariableLocation::LOOKUP: {
nit: Can we CHECK(!hole_init) here?

[adamk, 2016-06-09 16:12:36]

https://codereview.chromium.org/2051073004/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2051073004/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1134: case VariableLocation::LOOKUP: {
On 2016/06/09 16:10:33, Michael Starzinger wrote:
> nit: Can we CHECK(!hole_init) here?

Shall I add that in all the full-codegens too?

[Michael Starzinger, 2016-06-09 16:15:40]

https://codereview.chromium.org/2051073004/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2051073004/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1134: case VariableLocation::LOOKUP: {
On 2016/06/09 16:12:36, adamk wrote:
> On 2016/06/09 16:10:33, Michael Starzinger wrote:
> > nit: Can we CHECK(!hole_init) here?
> 
> Shall I add that in all the full-codegens too?

Hmm, yeah, good idea. Better err on the safe side. :)

[adamk, 2016-06-09 19:13:56]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-06-09 19:13:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2051073004/#ps20001
(title: "Added DCHECK(!hole_init) everywhere")

[commit-bot: I haz the power, 2016-06-09 19:14:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051073004/20001

[commit-bot: I haz the power, 2016-06-09 19:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 19:17:29]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/8589)

[adamk, 2016-06-09 19:27:08]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-06-09 19:27:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2051073004/#ps40001
(title: "Fix x64 build, add mips64")

[commit-bot: I haz the power, 2016-06-09 19:27:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051073004/40001

[commit-bot: I haz the power, 2016-06-09 19:51:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-09 19:53:15]

Description was changed from

==========
Remove more dead code now that legacy const is gone

Neither globals nor lookup slots can be hole-initialized anymore, thus
removing some dead code from the code generators and runtime-scopes.
==========

to

==========
Remove more dead code now that legacy const is gone

Neither globals nor lookup slots can be hole-initialized anymore, thus
removing some dead code from the code generators and runtime-scopes.

Committed: https://crrev.com/757221e574ecba543a65f4822c083aa860e030eb
Cr-Commit-Position: refs/heads/master@{#36876}
==========

[commit-bot: I haz the power, 2016-06-09 19:53:16]

Patchset 3 (id:??) landed as
https://crrev.com/757221e574ecba543a65f4822c083aa860e030eb
Cr-Commit-Position: refs/heads/master@{#36876}