Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2051073003: lkgr: src-side change to enable goma on the Win ASan bots (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

lkgr: src-side change to enable goma on the Win ASan bots https://codereview.chromium.org/2055623002 enabled goma on the Win ASan bots build-side (i.e. compile.py now starts goma and builds with -j200). Turn it on src-side as well so that gomacc gets actually used. BUG=618425 Committed: https://crrev.com/e0e0169bab2364d36a0b92a804287e2840127fda Cr-Commit-Position: refs/heads/master@{#399002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
I was wondering why the cycle time didn't change after turning on goma; this is ...
4 years, 6 months ago (2016-06-09 14:32:53 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-09 20:26:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051073003/1
4 years, 6 months ago (2016-06-09 20:39:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 20:45:55 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 20:46:06 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 20:47:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0e0169bab2364d36a0b92a804287e2840127fda
Cr-Commit-Position: refs/heads/master@{#399002}

Powered by Google App Engine
This is Rietveld 408576698