lkgr master: Port linux msan, tsan and windows asan bots to recipes

lkgr master: Port linux msan, tsan and windows asan bots to recipes

Depends on https://codereview.chromium.org/2051583002/

BUG=618425
Committed: https://chromium.googlesource.com/chromium/tools/build/+/0d230b31eb7052d502b716e4358fab14608f328c

[Nico, 2016-06-08 22:15:04]

Description was changed from

==========
lkgr master: Port linux msan, tsan and windows asan bots to recipes

BUG=618425
==========

to

==========
lkgr master: Port linux msan, tsan and windows asan bots to recipes

Depends on https://codereview.chromium.org/2051583002/

BUG=618425
==========

[Nico, 2016-06-08 22:15:18]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org, krasin@chromium.org

[Dirk Pranke, 2016-06-08 22:21:53]

lgtm, thanks also!

Hopefully you double-checked the GYP_DEFINES? The rest of the CL is
straightforward.

If you're on a tear here, you can also post a CL to remove the "Symbolized" ASAN
bots; we don't want them any more, but I haven't gotten around to shutting them
off.

[Nico, 2016-06-09 00:18:39]

On 2016/06/08 22:21:53, Dirk Pranke wrote:
> lgtm, thanks also!
> 
> Hopefully you double-checked the GYP_DEFINES? The rest of the CL is
> straightforward.

I did some checking (and will check a bit more before I hit cq), but I think in
real life the gyp defines now come from mb, and the bot-side config only
controls the GYP_DEFINES that are set during (non-gyp) runhooks – and most of
the time those shouldn't have an effect.

> If you're on a tear here, you can also post a CL to remove the "Symbolized"
ASAN
> bots; we don't want them any more, but I haven't gotten around to shutting
them
> off.

Oh cool, thanks for telling me! yes, I want to convert all bots on this master.

[Nico, 2016-06-09 00:24:11]

https://codereview.chromium.org/2055623002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_lkgr.py (right):

https://codereview.chromium.org/2055623002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_lkgr.py:100:
'chromium_apply_config': ['mb', 'tsan2', 'clobber'],
(this is missing debug_extra_cflags="-gline-tables-only" in GYP_DEFINES during
runhooks, but since the actual build files are written by mb, I figured that's
ok. everything else should match.)

[Nico, 2016-06-09 00:32:48]

Finished auditing. Another difference is that this enables goma on the win asan
bots, which I think should be a good change. I'll keep an eye on cycle time
though; no other bots we have build with clang-cl fastbuild=0 and goma (can't
imagine things getting slower though)

[Nico, 2016-06-09 00:32:52]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-06-09 00:32:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2055623002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-06-09 00:32:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055623002/40001

[commit-bot: I haz the power, 2016-06-09 00:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 00:41:10]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Nico, 2016-06-09 00:42:28]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-06-09 00:42:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2055623002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-06-09 00:42:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055623002/60001

[commit-bot: I haz the power, 2016-06-09 00:46:58]

Description was changed from

==========
lkgr master: Port linux msan, tsan and windows asan bots to recipes

Depends on https://codereview.chromium.org/2051583002/

BUG=618425
==========

to

==========
lkgr master: Port linux msan, tsan and windows asan bots to recipes

Depends on https://codereview.chromium.org/2051583002/

BUG=618425

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/0d230b31eb7052d502b7...
==========

[commit-bot: I haz the power, 2016-06-09 00:47:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/0d230b31eb7052d502b7...