Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2050973002: UseCounter: Count form submission in orphan tree. (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
Ilya Sherman, kochi
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UseCounter: Count form submission in orphan tree. BUG=618526 TBR=isherman@chromium.org Committed: https://crrev.com/762e6b648bd89034b9b611f40346644487378ad7 Cr-Commit-Position: refs/heads/master@{#398796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
tkent
kochi@, would you review this trivial CL please?
4 years, 6 months ago (2016-06-09 01:15:58 UTC) #2
kochi
rs lgtm
4 years, 6 months ago (2016-06-09 01:30:16 UTC) #3
tkent
TBRing isherman@ for histograms.xml
4 years, 6 months ago (2016-06-09 02:15:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050973002/1
4 years, 6 months ago (2016-06-09 02:15:34 UTC) #8
Ilya Sherman
histograms.xml lgtm
4 years, 6 months ago (2016-06-09 04:06:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/84701)
4 years, 6 months ago (2016-06-09 04:12:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050973002/1
4 years, 6 months ago (2016-06-09 05:06:42 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 06:22:43 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 06:23:51 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/762e6b648bd89034b9b611f40346644487378ad7
Cr-Commit-Position: refs/heads/master@{#398796}

Powered by Google App Engine
This is Rietveld 408576698