third_party/WebKit/Source/core/html/HTMLFormElement.cpp - Issue 2050973002: UseCounter: Count form submission in orphan tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 2050973002: UseCounter: Count form submission in orphan tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

index 026dcf70376d21047671b710d42602102d488f97..6b739a0b0328dac4b76c547d2a2612811c0a4c97 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

@@ -339,6 +339,9 @@ void HTMLFormElement::submit(Event* event, bool activateSubmitButton)

LocalFrame* frame = document().frame();

if (!view || !frame || !frame->page())

return;

+ // See crbug.com/586749.

+ if (!inShadowIncludingDocument())

+ UseCounter::count(document(), UseCounter::FormSubmissionNotInDocumentTree);

if (m_isSubmittingOrInUserJSSubmitEvent) {

m_shouldSubmit = true;