Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2050963002:
[Mac/iOS/GN] copy_bundle_data.py should preserve symlinks. (Closed)
|
Created:
4 years, 6 months ago by Robert Sesek Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac/iOS/GN] copy_bundle_data.py should preserve symlinks.
Bundled directory structures use symlinks relative to other components in the
bundle, and those should be preserved as symlinks, rather than copying the
file contents.
BUG=297668, 604809
R=sdefresne@chromium.org
Committed: https://crrev.com/c83d846a78e4d291bee8681bab917af7b9e12faf
Cr-Commit-Position: refs/heads/master@{#398880}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 18 (5 generated)
Description was changed from ========== [Mac/iOS/GN] copy_bundle_data.py should preserve symlinks. Bundled directory structures use symlinks relative to other components in the bundle, and those should be preserved as symlinks, rather than copying the file contents. BUG=297668 R=sdefresne@chromium.org ========== to ========== [Mac/iOS/GN] copy_bundle_data.py should preserve symlinks. Bundled directory structures use symlinks relative to other components in the bundle, and those should be preserved as symlinks, rather than copying the file contents. BUG=297668,604809 R=sdefresne@chromium.org ==========
lgtm
+thakis for OWNERS
rsesek@chromium.org changed reviewers: + thakis@chromium.org
+thakis for OWNERS
https://codereview.chromium.org/2050963002/diff/1/build/toolchain/mac/copy_bu... File build/toolchain/mac/copy_bundle_data.py (right): https://codereview.chromium.org/2050963002/diff/1/build/toolchain/mac/copy_bu... build/toolchain/mac/copy_bundle_data.py:73: # be consistent with the single-file branch. it looks like this was copy-pasted from somewhere...why wasn't this needed where it's from?
https://codereview.chromium.org/2050963002/diff/1/build/toolchain/mac/copy_bu... File build/toolchain/mac/copy_bundle_data.py (right): https://codereview.chromium.org/2050963002/diff/1/build/toolchain/mac/copy_bu... build/toolchain/mac/copy_bundle_data.py:73: # be consistent with the single-file branch. On 2016/06/09 14:20:53, Nico wrote: > it looks like this was copy-pasted from somewhere...why wasn't this needed where > it's from? It was a boog from before. We never included symlinks in our bundle, but we may start doing so in the future if we start versioning the Chrome Framework (which I am proposing we do...).
ok, so the BUG=297668 isn't really true? lgtm then
On 2016/06/09 14:35:13, Nico wrote: > ok, so the BUG=297668 isn't really true? lgtm then Why isn't it really true? It's the roll-up bug for all the Mac GN bundle support.
it sounded like this is for a future bundling change, and not needed for the current bundle behavior, while the bug sounds to me like "make current bundles work". sorry for bug number bikeshedding though, ignore me
On 2016/06/09 14:44:14, Nico wrote: > it sounded like this is for a future bundling change, and not needed for the > current bundle behavior, while the bug sounds to me like "make current bundles > work". > > sorry for bug number bikeshedding though, ignore me That's true, but it's also objectively wrong to not copy symlinks when bundling, since the OS X framework structure typically (always? I think we're technically incorrect) necessitates them. 🚲 🏡
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050963002/1
Message was sent while issue was closed.
Description was changed from ========== [Mac/iOS/GN] copy_bundle_data.py should preserve symlinks. Bundled directory structures use symlinks relative to other components in the bundle, and those should be preserved as symlinks, rather than copying the file contents. BUG=297668,604809 R=sdefresne@chromium.org ========== to ========== [Mac/iOS/GN] copy_bundle_data.py should preserve symlinks. Bundled directory structures use symlinks relative to other components in the bundle, and those should be preserved as symlinks, rather than copying the file contents. BUG=297668,604809 R=sdefresne@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Mac/iOS/GN] copy_bundle_data.py should preserve symlinks. Bundled directory structures use symlinks relative to other components in the bundle, and those should be preserved as symlinks, rather than copying the file contents. BUG=297668,604809 R=sdefresne@chromium.org ========== to ========== [Mac/iOS/GN] copy_bundle_data.py should preserve symlinks. Bundled directory structures use symlinks relative to other components in the bundle, and those should be preserved as symlinks, rather than copying the file contents. BUG=297668,604809 R=sdefresne@chromium.org Committed: https://crrev.com/c83d846a78e4d291bee8681bab917af7b9e12faf Cr-Commit-Position: refs/heads/master@{#398880} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c83d846a78e4d291bee8681bab917af7b9e12faf Cr-Commit-Position: refs/heads/master@{#398880} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
