build/toolchain/mac/copy_bundle_data.py - Issue 2050963002: [Mac/iOS/GN] copy_bundle_data.py should preserve symlinks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/mac/copy_bundle_data.py

Issue 2050963002: [Mac/iOS/GN] copy_bundle_data.py should preserve symlinks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/mac/copy_bundle_data.py

diff --git a/build/toolchain/mac/copy_bundle_data.py b/build/toolchain/mac/copy_bundle_data.py

index 5392572ee454d3614ed1c6f395139754b14643f3..976591c08ee309a1df86d71d3bd6ce66d3865edc 100644

--- a/build/toolchain/mac/copy_bundle_data.py

+++ b/build/toolchain/mac/copy_bundle_data.py

@@ -71,7 +71,7 @@ def copy_file(source, dest):

# TODO(thakis): This copies file attributes like mtime, while the

# single-file branch below doesn't. This should probably be changed to

# be consistent with the single-file branch.

Nico 2016/06/09 14:20:53 it looks like this was copy-pasted from somewhere.

Robert Sesek 2016/06/09 14:22:35 It was a boog from before. We never included symli

- shutil.copytree(source, dest)

+ shutil.copytree(source, dest, symlinks=True)

return

if os.path.exists(dest):

« no previous file with comments | « no previous file | no next file » | no next file with comments »