MD Settings: About page, fix bug causing update status message to not update.

MD Settings: About page, fix bug causing update status message to not update.

The bug was twofold
 1) Non ChromeOS data binding should not depend on targetChannel_, since
    targetChannel_ is only defined for ChromeOS.
 2) There was a typo in the HTML data binding, s/targetChannel/targetChannel_.

Previous test was only checking that the update status icon was updated, without
making assertions about the update status message.

BUG=546841, 603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d7c62a79b8d747b5cdcdd163abff3839aceca8f
Cr-Commit-Position: refs/heads/master@{#399011}

[dpapad, 2016-06-08 23:36:58]

Description was changed from

==========
MD Settings: About page, fix bug causing update status message to not update.

The bug was twofold
 1) Non ChromeOS data binding should not depend on targetChannel_, since
    targetChannel_ is only defined for ChromeOS.
 2) There was a typo in the HTML data binding, s/targetChannel/targetChannel_.

Previous test was only checking that the update status icon was updated, without
making assertions about the update status message.

BUG=546841,603625
==========

to

==========
MD Settings: About page, fix bug causing update status message to not update.

The bug was twofold
 1) Non ChromeOS data binding should not depend on targetChannel_, since
    targetChannel_ is only defined for ChromeOS.
 2) There was a typo in the HTML data binding, s/targetChannel/targetChannel_.

Previous test was only checking that the update status icon was updated, without
making assertions about the update status message.

BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-08 23:37:47]

Patchset #2 (id:20001) has been deleted

[dpapad, 2016-06-08 23:55:25]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2016-06-09 18:40:44]

lgtm with optional nit

https://codereview.chromium.org/2050903002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2050903002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:83:
currentUpdateStatusEvent_)]]
Ah...

My only suggestion would be to not split up the binding call to make it more
clear for a reader. (even though you are repeating the fn name twice.

<if expr="not chromeos">
  [[foo_(bar)]]
</if>
<if expr="chromeos">
  [[foo_(bar, baz)]]
</if>

[dpapad, 2016-06-09 18:59:52]

Thanks!

https://codereview.chromium.org/2050903002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2050903002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:83:
currentUpdateStatusEvent_)]]
On 2016/06/09 at 18:40:44, tommycli wrote:
> Ah...
> 
> My only suggestion would be to not split up the binding call to make it more
clear for a reader. (even though you are repeating the fn name twice.
> 
> <if expr="not chromeos">
>   [[foo_(bar)]]
> </if>
> <if expr="chromeos">
>   [[foo_(bar, baz)]]
> </if>

Done.

[dpapad, 2016-06-09 19:01:03]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-06-09 19:01:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2050903002/#ps40001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-06-09 19:01:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050903002/40001

[commit-bot: I haz the power, 2016-06-09 20:08:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 20:08:48]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2016-06-09 20:34:03]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-06-09 20:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050903002/40001

[commit-bot: I haz the power, 2016-06-09 20:57:11]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-09 20:59:55]

Description was changed from

==========
MD Settings: About page, fix bug causing update status message to not update.

The bug was twofold
 1) Non ChromeOS data binding should not depend on targetChannel_, since
    targetChannel_ is only defined for ChromeOS.
 2) There was a typo in the HTML data binding, s/targetChannel/targetChannel_.

Previous test was only checking that the update status icon was updated, without
making assertions about the update status message.

BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, fix bug causing update status message to not update.

The bug was twofold
 1) Non ChromeOS data binding should not depend on targetChannel_, since
    targetChannel_ is only defined for ChromeOS.
 2) There was a typo in the HTML data binding, s/targetChannel/targetChannel_.

Previous test was only checking that the update status icon was updated, without
making assertions about the update status message.

BUG=546841,603625
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d7c62a79b8d747b5cdcdd163abff3839aceca8f
Cr-Commit-Position: refs/heads/master@{#399011}
==========

[commit-bot: I haz the power, 2016-06-09 20:59:56]

Patchset 2 (id:??) landed as
https://crrev.com/2d7c62a79b8d747b5cdcdd163abff3839aceca8f
Cr-Commit-Position: refs/heads/master@{#399011}