Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/browser/resources/settings/about_page/about_page.html

Issue 2050903002: MD Settings: About page, fix bug causing update status message to not update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/about_page_tests.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="/about_page/about_page_browser_proxy.html"> 2 <link rel="import" href="/about_page/about_page_browser_proxy.html">
3 <link rel="import" href="/i18n_setup.html"> 3 <link rel="import" href="/i18n_setup.html">
4 <link rel="import" href="/icons.html"> 4 <link rel="import" href="/icons.html">
5 <link rel="import" href="/settings_page/main_page_behavior.html"> 5 <link rel="import" href="/settings_page/main_page_behavior.html">
6 <link rel="import" href="/settings_page/settings_animated_pages.html"> 6 <link rel="import" href="/settings_page/settings_animated_pages.html">
7 <link rel="import" href="/settings_page/settings_section.html"> 7 <link rel="import" href="/settings_page/settings_section.html">
8 <link rel="import" href="/settings_page_css.html"> 8 <link rel="import" href="/settings_page_css.html">
9 <link rel="import" href="/settings_shared_css.html"> 9 <link rel="import" href="/settings_shared_css.html">
10 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 10 <link rel="import" href="chrome://resources/cr_elements/icons.html">
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 <iron-icon 71 <iron-icon
72 hidden="[[!shouldShowUpdateStatusIcon_( 72 hidden="[[!shouldShowUpdateStatusIcon_(
73 currentUpdateStatusEvent_)]]" 73 currentUpdateStatusEvent_)]]"
74 icon$="[[getIcon_(currentUpdateStatusEvent_)]]" 74 icon$="[[getIcon_(currentUpdateStatusEvent_)]]"
75 src="[[getIconSrc_(currentUpdateStatusEvent_)]]"> 75 src="[[getIconSrc_(currentUpdateStatusEvent_)]]">
76 </iron-icon> 76 </iron-icon>
77 <div class="start"> 77 <div class="start">
78 <div id="updateStatusMessage" 78 <div id="updateStatusMessage"
79 hidden="[[!shouldShowUpdateStatusMessage_( 79 hidden="[[!shouldShowUpdateStatusMessage_(
80 currentUpdateStatusEvent_)]]"> 80 currentUpdateStatusEvent_)]]">
81 <if expr="not chromeos">
82 [[getUpdateStatusMessage_(currentUpdateStatusEvent_)]]
83 </if>
84 <if expr="chromeos">
81 [[getUpdateStatusMessage_( 85 [[getUpdateStatusMessage_(
82 currentUpdateStatusEvent_,targetChannel)]] 86 currentUpdateStatusEvent_, targetChannel_)]]
87 </if>
83 </div> 88 </div>
84 <span id="deprecationWarning" 89 <span id="deprecationWarning"
85 hidden="[[!obsoleteSystemInfo_.obsolete]]"> 90 hidden="[[!obsoleteSystemInfo_.obsolete]]">
86 $i18n{aboutObsoleteSystem} 91 $i18n{aboutObsoleteSystem}
87 <a href="$i18n{aboutObsoleteSystemURL}" target="_blank"> 92 <a href="$i18n{aboutObsoleteSystemURL}" target="_blank">
88 $i18n{learnMore} 93 $i18n{learnMore}
89 </a> 94 </a>
90 </span> 95 </span>
91 <div class="secondary">$i18n{aboutBrowserVersion}</div> 96 <div class="secondary">$i18n{aboutBrowserVersion}</div>
92 </div> 97 </div>
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 <settings-detailed-build-info></settings-detailed-build-info> 164 <settings-detailed-build-info></settings-detailed-build-info>
160 </settings-subpage> 165 </settings-subpage>
161 </template> 166 </template>
162 </if> 167 </if>
163 </settings-animated-pages> 168 </settings-animated-pages>
164 </settings-section> 169 </settings-section>
165 </div> 170 </div>
166 </template> 171 </template>
167 <script src="about_page.js"></script> 172 <script src="about_page.js"></script>
168 </dom-module> 173 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/about_page_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698