Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2050863003: [Telemetry] Move the deprecate decorator of form_based_credentials_backend to LoginNeeded method (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Move the deprecate decorator of form_based_credentials_backend to LoginNeeded method This makes it less spammy for benchmarks that don't actually use this code path. BUG=catapult:#2318 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6540f08432a9778e1d8136a3e9adac978f01de1b

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M telemetry/telemetry/internal/backends/form_based_credentials_backend.py View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nednguyen
4 years, 6 months ago (2016-06-09 01:36:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050863003/1
4 years, 6 months ago (2016-06-09 01:36:17 UTC) #5
sullivan
lgtm
4 years, 6 months ago (2016-06-09 02:46:39 UTC) #6
perezju
this works! thanks, lgtm
4 years, 6 months ago (2016-06-09 09:41:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050863003/20001
4 years, 6 months ago (2016-06-09 12:08:48 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 12:43:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698