Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: telemetry/telemetry/internal/backends/form_based_credentials_backend.py

Issue 2050863003: [Telemetry] Move the deprecate decorator of form_based_credentials_backend to LoginNeeded method (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/form_based_credentials_backend.py
diff --git a/telemetry/telemetry/internal/backends/form_based_credentials_backend.py b/telemetry/telemetry/internal/backends/form_based_credentials_backend.py
index 15b638101aa36aa1bec142dc54f7cc6e5c5c3d60..c2c23dc69315de2e25be88dcc86fd990a8952264 100644
--- a/telemetry/telemetry/internal/backends/form_based_credentials_backend.py
+++ b/telemetry/telemetry/internal/backends/form_based_credentials_backend.py
@@ -7,11 +7,6 @@ from telemetry import decorators
from telemetry.core import exceptions
-# pylint: disable=line-too-long
-@decorators.Deprecated(2017, 5, 5, 'Use the login helper modules in '
- 'https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_sets/login_helpers/'
- ' instead.')
-# pylint: enable=line-too-long
class FormBasedCredentialsBackend(object):
def __init__(self):
self._logged_in = False
@@ -81,7 +76,13 @@ class FormBasedCredentialsBackend(object):
# Wait for the form element to disappear as confirmation of the navigation.
action_runner.WaitForNavigate()
-
+ # pylint: disable=line-too-long
+ @decorators.Deprecated(2017, 5, 5,
+ 'FormBasedCredentialsBackend is deprecated. Use the '
+ 'login helper modules in '
+ 'https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_sets/login_helpers/'
+ ' instead.')
+ # pylint: enable=line-too-long
def LoginNeeded(self, tab, action_runner, config):
"""Logs in to a test account.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698