[turbofan] Introduce CheckIf node (deopt without explicit frame state).

[turbofan] Introduce CheckIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagate the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckIf.

BUG=

Committed: https://crrev.com/f2312019aff98ea33a6a2f29cfaf3a7247e259a1
Cr-Commit-Position: refs/heads/master@{#36839}

[Jarin, 2016-06-08 20:56:51]

Description was changed from

==========
[turbofan] Introduce CheckedIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagare the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckedIf.

BUG=
==========

to

==========
[turbofan] Introduce CheckedIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagare the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckedIf.

BUG=
==========

[Jarin, 2016-06-08 20:56:51]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Jarin, 2016-06-09 05:09:40]

Could you take a look, please?

[Jarin, 2016-06-09 05:10:16]

Description was changed from

==========
[turbofan] Introduce CheckedIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagare the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckedIf.

BUG=
==========

to

==========
[turbofan] Introduce CheckIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagate the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckIf.

BUG=
==========

[Benedikt Meurer, 2016-06-09 05:12:49]

lgtm

[Jarin, 2016-06-09 05:13:02]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2016-06-09 05:13:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050813003/20001

[commit-bot: I haz the power, 2016-06-09 05:40:07]

Description was changed from

==========
[turbofan] Introduce CheckIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagate the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckIf.

BUG=
==========

to

==========
[turbofan] Introduce CheckIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagate the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckIf.

BUG=
==========

[commit-bot: I haz the power, 2016-06-09 05:40:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-09 05:41:27]

Description was changed from

==========
[turbofan] Introduce CheckIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagate the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckIf.

BUG=
==========

to

==========
[turbofan] Introduce CheckIf node (deopt without explicit frame state).

Type feedback introduced DeoptimizeIf node in representation inference
(for Int32AddWithOverflow); we found the frame state for the deopt by
walking the effect chain. Unfortunately, the effect chain can hit
effect merges introduced by simplified lowering (e.g., in LoadBuffer)
and thus fail the assertion (we refuse to go through effect phis).

This CL postpones assignment of the frame state to the effect-control
lninearizer, so that we can correctly propagate the frame state to
the deopt point. The DeoptimizeIf node with unassigned frame state is
called CheckIf.

BUG=

Committed: https://crrev.com/f2312019aff98ea33a6a2f29cfaf3a7247e259a1
Cr-Commit-Position: refs/heads/master@{#36839}
==========

[commit-bot: I haz the power, 2016-06-09 05:41:27]

Patchset 2 (id:??) landed as
https://crrev.com/f2312019aff98ea33a6a2f29cfaf3a7247e259a1
Cr-Commit-Position: refs/heads/master@{#36839}